Shim/integration program todos/init fast market order #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengtlofgren
force-pushed
the
shim/integration_program-todos/init-fast-market-order
branch
from
d6c3742 to
6292726
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressing todos in the instruction for the initialize_fast_market_order
Changes
FastMarketOrderParamsstruct instead of theFastMarketOrderaccount structclose_account_refund_recipientCurrently failing tests
There are currently a few failing tests that use custom actors to initialize fast market orders and close them. I suspect this is mainly logic on the testing side that hasn't accommodated the new changes to the program, but needs further investigation and work. Until these tests are fixed, do NOT change into a PR from Draft